Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add elasticsearch-sink integration test to the integration test workflow #13612

Merged
merged 17 commits into from
Nov 23, 2023
Merged

test: add elasticsearch-sink integration test to the integration test workflow #13612

merged 17 commits into from
Nov 23, 2023

Conversation

xuefengze
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

timestamp is not supported, #13585

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xuefengze xuefengze requested a review from lmatz November 23, 2023 07:15
@github-actions github-actions bot added the component/test Test related issue. label Nov 23, 2023
lmatz
lmatz approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@lmatz lmatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@codecov Codecov
Copy link

codecov bot commented Nov 23, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8deba24) 68.15% compared to head (9a59e2d) 68.21%.
Report is 17 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #13612      +/-   ##
==========================================
+ Coverage   68.15%   68.21%   +0.05%     
==========================================
  Files        1513     1513              
  Lines      261013   261013              
==========================================
+ Hits       177892   178038     +146     
+ Misses      83121    82975     -146
Flag Coverage Δ
rust 68.21% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xuefengze xuefengze added this pull request to the merge queue Nov 23, 2023
Merged via the queue into main with commit f4288ce Nov 23, 2023
28 of 29 checks passed
@xuefengze xuefengze deleted the fengze/add_elasticsearch_sink_workflow branch November 23, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmatz lmatz lmatz approved these changes

Assignees
No one assigned
Labels
component/test Test related issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xuefengze @lmatz